Ticket #148 (closed defect: fixed)

Opened 3 months ago

Last modified 2 months ago

scapy/layers/dhcp.py missing import of IP and Ether

Reported by: dickon@cantab.net Assigned to: pbi
Priority: major Milestone:
Component: Scapy Version:
Keywords: Cc:

Description

I tried to use DHCP_am, and got some NameErrors? which I did not expect.

This was in scapy/layers/dhcp.py as of:

changeset: 937:cdea8d8a25ea user: Phil <phil@secdev.org> date: Wed Oct 01 19:07:27 2008 +0200 summary: Added tag v2.0.0.10 for changeset 86518fb3c5ad

[root@coyote30 scapy]# ./test_dhcp_server.py got request from 00:0f:53:04:01:08 Traceback (most recent call last):

File "./test_dhcp_server.py", line 15, in <module>

MyDHCP_am()(iface='eth2')

File "/home/dr/src/scapy/scapy/ansmachine.py", line 120, in call

self.sniff()

File "/home/dr/src/scapy/scapy/ansmachine.py", line 125, in sniff

sniff(**self.optsniff)

File "/home/dr/src/scapy/scapy/sendrecv.py", line 559, in sniff

r = prn(p)

File "/home/dr/src/scapy/scapy/ansmachine.py", line 103, in reply

reply = self.make_reply(pkt)

File "/home/dr/src/scapy/scapy/layers/dhcp.py", line 347, in make_reply

resp = BOOTP_am.make_reply(self, req)

File "/home/dr/src/scapy/scapy/layers/dhcp.py", line 340, in make_reply

rep=Ether(dst=mac)/IP(dst=ip)/UDP(sport=req.dport,dport=req.sport)/repb

NameError?: global name 'Ether' is not defined [root@coyote30 scapy]# ./test_dhcp_server.py got request from 00:0f:53:04:01:08 Traceback (most recent call last):

File "./test_dhcp_server.py", line 15, in <module>

MyDHCP_am()(iface='eth2')

File "/home/dr/src/scapy/scapy/ansmachine.py", line 120, in call

self.sniff()

File "/home/dr/src/scapy/scapy/ansmachine.py", line 125, in sniff

sniff(**self.optsniff)

File "/home/dr/src/scapy/scapy/sendrecv.py", line 559, in sniff

r = prn(p)

File "/home/dr/src/scapy/scapy/ansmachine.py", line 103, in reply

reply = self.make_reply(pkt)

File "/home/dr/src/scapy/scapy/layers/dhcp.py", line 348, in make_reply

resp = BOOTP_am.make_reply(self, req)

File "/home/dr/src/scapy/scapy/layers/dhcp.py", line 341, in make_reply

rep=Ether(dst=mac)/IP(dst=ip)/UDP(sport=req.dport,dport=req.sport)/repb

NameError?: global name 'IP' is not defined

Attachments

scapy_dhcp_name_errors.patch (0.7 kB) - added by dickon@cantab.net on 10/23/08 12:46:39.
proposed patch

Change History

10/23/08 12:46:39 changed by dickon@cantab.net

  • attachment scapy_dhcp_name_errors.patch added.

proposed patch

10/25/08 17:23:49 changed by pbi

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in [08c59479d899]


Add/Change #148 (scapy/layers/dhcp.py missing import of IP and Ether)




Change Properties
Action